Review Request 113008: Clean up KWallet before moving to its own tier

Valentin Rusu kde at rusu.info
Wed Oct 2 18:51:20 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113008/#review41142
-----------------------------------------------------------

Ship it!


Ship It!

- Valentin Rusu


On Oct. 2, 2013, 12:53 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113008/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2013, 12:53 a.m.)
> 
> 
> Review request for KDE Frameworks and Valentin Rusu.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Makes a bit of sense of the cmake, adds a TODO.
> 
> 
> Diffs
> -----
> 
>   staging/kwallet/src/CMakeLists.txt 0aaa39e 
>   staging/kwallet/src/kwallet_mac.cpp d5d522b 
> 
> Diff: http://git.reviewboard.kde.org/r/113008/diff/
> 
> 
> Testing
> -------
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131002/bd471b22/attachment.html>


More information about the Kde-frameworks-devel mailing list