Review Request 113052: Remove find_package calls from root kdelibs

Stephen Kelly steveire at gmail.com
Wed Oct 2 16:03:40 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113052/#review41128
-----------------------------------------------------------

Ship it!


Ship It!

- Stephen Kelly


On Oct. 2, 2013, 3:54 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113052/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2013, 3:54 p.m.)
> 
> 
> Review request for KDE Frameworks and Stephen Kelly.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> As suggested by a kdelibs_cleanups task, move all find_package usages to its own module.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a33ab62 
>   dnssd/CMakeLists.txt 053b897 
>   dnssd/src/CMakeLists.txt d392cbe 
>   experimental/CMakeLists.txt 30a2ff8 
>   experimental/kdeclarative/CMakeLists.txt a4c8982 
>   interfaces/CMakeLists.txt 8a3a2fc 
>   kded/CMakeLists.txt d373cdb 
>   kdesu/CMakeLists.txt a004c82 
>   kdewidgets/CMakeLists.txt d8b8542 
>   kfile/CMakeLists.txt b62973d 
>   khtml/CMakeLists.txt 4ce8fce 
>   kinit/CMakeLists.txt 4ae92f3 
>   kio/CMakeLists.txt 18a9962 
>   kioslave/CMakeLists.txt 3b957ae 
>   kioslave/http/CMakeLists.txt 97a5a4b 
>   kioslave/http/kcookiejar/tests/CMakeLists.txt e41731a 
>   kioslave/http/tests/CMakeLists.txt 590e2be 
>   kjsembed/CMakeLists.txt 15450b5 
>   knewstuff/CMakeLists.txt 3fccbc6 
>   knotify/CMakeLists.txt 8c3bf50 
>   kpty/CMakeLists.txt 9a79827 
>   kross/CMakeLists.txt 014f5c9 
>   kross/modules/CMakeLists.txt d22a11c 
>   staging/CMakeLists.txt 0f608c7 
>   staging/frameworkintegration/CMakeLists.txt 58776b0 
>   staging/frameworkintegration/autotests/CMakeLists.txt c203019 
>   staging/kbookmarks/autotests/CMakeLists.txt b1e031b 
>   staging/kde4attic/CMakeLists.txt 44cbc17 
>   staging/kde4attic/src/CMakeLists.txt c7c4373 
>   staging/kde4support/CMakeLists.txt 3f13677 
>   staging/kde4support/src/CMakeLists.txt bab81e6 
>   staging/kinterprocesswindowing/CMakeLists.txt PRE-CREATION 
>   staging/kinterprocesswindowing/src/CMakeLists.txt PRE-CREATION 
>   staging/kio/CMakeLists.txt f9afb6d 
>   staging/kio/src/widgets/CMakeLists.txt 35eae7e 
>   staging/kjobwidgets/CMakeLists.txt c1e769e 
>   staging/kjobwidgets/src/CMakeLists.txt 46d1a6e 
>   staging/kwallet/CMakeLists.txt 02c3d7b 
>   tier1/itemviews/CMakeLists.txt e13ea0e 
>   tier1/kconfig/CMakeLists.txt d6fe4f7 
>   tier1/kidletime/CMakeLists.txt ed801f4 
>   tier1/kidletime/src/CMakeLists.txt b005120 
>   tier1/kjs/CMakeLists.txt 2385027 
>   tier1/kwidgetsaddons/CMakeLists.txt 765d2f1 
>   tier1/kwindowsystem/CMakeLists.txt dde412d 
>   tier1/kwindowsystem/src/CMakeLists.txt ea0f313 
>   tier2/kauth/CMakeLists.txt 6fe7f68 
>   tier2/kcrash/CMakeLists.txt 8879784 
>   tier2/ki18n/CMakeLists.txt be337de 
>   tier2/knotifications/CMakeLists.txt 5e1b4cc 
>   tier2/knotifications/src/CMakeLists.txt 7c52664 
>   tier3/kconfigwidgets/CMakeLists.txt a212a11 
>   tier3/kprintutils/CMakeLists.txt dd8c403 
>   tier3/kprintutils/src/CMakeLists.txt 5d797d1 
>   tier3/ktextwidgets/CMakeLists.txt a8b4aa9 
>   tier3/xmlgui/CMakeLists.txt a45d86d 
>   tier3/xmlgui/src/CMakeLists.txt 9677b0a 
> 
> Diff: http://git.reviewboard.kde.org/r/113052/diff/
> 
> 
> Testing
> -------
> 
> Everything keeps building
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131002/bb8899ed/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list