Review Request 113050: Use enum for KMessageBox return types

Aleix Pol Gonzalez aleixpol at kde.org
Wed Oct 2 14:47:02 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113050/#review41120
-----------------------------------------------------------


I like the idea of being more specific about the return value, but isn't this going to break source compatibility?

- Aleix Pol Gonzalez


On Oct. 2, 2013, 2:43 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113050/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2013, 2:43 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Use enum for KMessageBox return types instead of int.
> 
> 
> Diffs
> -----
> 
>   staging/kde4support/src/kdeui/kmessagebox_queued.cpp 00e9eb0 
>   tier1/kwidgetsaddons/src/kmessagebox.h 4d1306b 
>   tier1/kwidgetsaddons/src/kmessagebox.cpp d974cd6 
> 
> Diff: http://git.reviewboard.kde.org/r/113050/diff/
> 
> 
> Testing
> -------
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131002/0f9e7c01/attachment.html>


More information about the Kde-frameworks-devel mailing list