Review Request 113049: Fix libAttica build
Martin Klapetek
martin.klapetek at gmail.com
Wed Oct 2 14:39:50 UTC 2013
> On Oct. 2, 2013, 2:20 p.m., Stephen Kelly wrote:
> > Does this make attica independent of ECM? Does it still need to find ECM?
Actually yes. So I'll remove the find_package(ECM...) too and push.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113049/#review41117
-----------------------------------------------------------
On Oct. 2, 2013, 2:07 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113049/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2013, 2:07 p.m.)
>
>
> Review request for Attica and KDE Frameworks.
>
>
> Repository: attica
>
>
> Description
> -------
>
> There were 2 files recently removed from ECM which broke attica's build, this puts the removed files as local cmake modules.
>
>
> Diffs
> -----
>
> CMakeLists.txt e0efb9b
> cmake/modules/ECMQt4To5Porting.cmake PRE-CREATION
> cmake/modules/FindQt5Transitional.cmake PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/113049/diff/
>
>
> Testing
> -------
>
> Builds again.
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131002/86a65f4d/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list