Review Request 113045: Prepare KCMUtils for move to tier3

Stephen Kelly steveire at gmail.com
Wed Oct 2 12:16:41 UTC 2013


David Edmundson wrote:

> 
> 
>> On Oct. 2, 2013, 11:02 a.m., Aleix Pol Gonzalez wrote:
>> > staging/kcmutils/CMakeLists.txt, line 23
>> > 
<http://git.reviewboard.kde.org/r/113045/diff/1/?file=193397#file193397line23>
>> >
>> >     Why removing these?
> 
> As I understand it everything should compile with -DQT_NO_CAST_TO_ASCII,
> it was previously added here to make it compile before all the "blah" ->
> QLiteralString("blah") changes.
> 

This discussion is exactly why you are supposed to make changes like this 
before the move in a separate patch, so that you can explain the above in a 
commit message. 

Then the move commit is 'clean'.

Thanks,

Steve.




More information about the Kde-frameworks-devel mailing list