Review Request 112730: add CMake changes to knewstuff

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112730/
-----------------------------------------------------------

(Updated Oct. 1, 2013, 7:01 p.m.)


Review request for KDE Frameworks, Albert Astals Cid, David Faure, and Chusslove Illich.


Changes
-------

Updated to include KNewStuffConfig.cmake.in

I still don't understand what should be in the different target_link_libraries calls though.


Summary (updated)
-----------------

add CMake changes to knewstuff


Repository: kdelibs


Description
-------

This makes it so I can mkdir build; cd build; cmake ../; make install from knewstuff sources.
It's still using KDE4_KIO_LIBS and find_package(KIO) since not all of the kio libraries have been split out apparently.
I'm not sure why sources had to be changed, but I had to add includes of klocalizedstring where we didn't need them before somehow.


Diffs (updated)
-----

  knewstuff/CMakeLists.txt 3fccbc6ee01a1cc8920321ee7125efb0bfc68412 
  knewstuff/KNewStuffConfig.cmake.in PRE-CREATION 
  knewstuff/src/CMakeLists.txt c31398159459b79160ef76f193d6208d19953b4d 
  knewstuff/src/downloaddialog.cpp 3294c7c04c7879320fc0949db0310868bd6fa4fa 
  knewstuff/src/downloadwidget.cpp 64b7673d67b4e2f15007fc1a3f57d3da844d1dc0 
  knewstuff/src/ui/entrydetailsdialog.cpp 65b75d79941d9026f368f82c7b6df91d754e0925 
  knewstuff/src/uploaddialog.cpp dbde573e8c3a477755c8c866d0ca1fccd1a35729 

Diff: http://git.reviewboard.kde.org/r/112730/diff/


Testing
-------

It builds and installs.


Thanks,

Jeremy Whiting

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131002/3a06e708/attachment-0001.html>