Review Request 112880: Added KColorSchemeToken class.

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/#review41068
-----------------------------------------------------------


I'm not a huge fan of using Q_INVOKABLE for something that actually looks more like a property. There's something to be said for keeping this object static, as otherwise it could grow a bit big, so I wouldn't regard this as a showstopper. (As we don't have really dynamic properties, we'd likely to a lot of work and keep too much things in memory.)


kdeui/colors/kcolorschemetoken.h
<http://git.reviewboard.kde.org/r/112880/#comment30145>

    Maybe add example calls for this, easy to copy (and still get right). I totally see people getting it wrong. :)



kdeui/colors/kcolorschemetoken.h
<http://git.reviewboard.kde.org/r/112880/#comment30144>

    using int here loses the type-safety. Why no use the corresponding enums? It would also make the code more readable.
    
    (Same issue for all the other methods.)


- Sebastian Kügler


On Sept. 29, 2013, 4:27 p.m., Denis Kuplyakov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112880/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2013, 4:27 p.m.)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> It is wrapper to access KColorScheme's methods from QML code.
> Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them accessible from QML code.
> 
> As it will be accepted, QML-clone of KgPopupItem will be posted for review to libkdegames, as it uses it to access KDE's color theme.
> 
> More info:
> * search for "KDE theme colors API for QML" thread at kdelibs and kdegames mailinglists *
> 
> 
> Diffs
> -----
> 
>   includes/CMakeLists.txt cdf0143 
>   includes/KColorSchemeToken PRE-CREATION 
>   kdeui/CMakeLists.txt b439e04 
>   kdeui/colors/kcolorscheme.h 17570fd 
>   kdeui/colors/kcolorscheme.cpp a6650ac 
>   kdeui/colors/kcolorschemetoken.h PRE-CREATION 
>   kdeui/colors/kcolorschemetoken.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112880/diff/
> 
> 
> Testing
> -------
> 
> I've tested it with KReversi's deniskup/gsoc2013/newdesign branch.
> 
> 
> Thanks,
> 
> Denis Kuplyakov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131001/1706b378/attachment.html>