Dialogs, QPT and Qt5

[Albert Astals Cid]

El Divendres, 29 de novembre de 2013, a les 12:22:48, Kevin Ottens va 
escriure:
> On Friday 29 November 2013 12:00:38 Christoph Feck wrote:
> > On Friday 29 November 2013 08:53:06 Kevin Ottens wrote:
> > > KColorDialog and KFontDialog are out of the picture. We contributed
> > > to the upstream QColorDialog and QFontDialog so that they have the
> > > features we needed out of the box. We only need to do something
> > > for the file dialog.
> > 
> > Not sure if we can silently drop the K classes.
> > 
> > KFontDialog:
> > - allows the application to specify a list of fonts to show
> 
> To upstream if that's used (IIRC we didn't find users of that).
> 
> > - allows the application to request fixed-width fonts only
> 
> That's upstream.
> 
> > - allows limiting to only change family, style, or size
> 
> To upstream if that's used (IIRC almost no user again).
> 
> > - supports fractional point sizes, e.g. 9.4 pt.
> 
> To upstream if needed.
> 
> > - word wraps and scrolls big sample texts
> 
> To upstream.
> 
> > KColorDialog:
> > - allows the application to specify a default color, where the user
> > can revert to
> 
> To upstream.
> 
> > - supports both RGB and HSV color models
> 
> Looks like QColorDialog does too, or I'm missing something?
> 
> > - has support for loadable palettes (editable via kcoloredit)
> 
> OK, that one is indeed missing. And if we want to upstream that it'll
> require more work than the rest.
> 
> > - appearantly the color picker and hex line edit have been upstreamed,
> > but I just tried Qt 5.3 Designer, and those features did not appear.
> 
> Odd, I see them here.
> 
> 
> Overall my point is that it's mostly features which really belongs upstream.

Right, but they don't exist at the moment, do they?

Why do you hate those features and need to kill them now?

What about apps that use those features? What are we going to tell the 
developers? "Sorry but your feature was not really important so we killed it, 
but don't worry KDE loves you!"

Doesn't feel right.

Cheers,
  Albert

> And they're either stuff we can contribute at any point or stuff which is
> unused. The only exception seems to be the loadable palettes, but that's
> not enough to warrant having a full fledged color dialog on our side IMO.
> So if that's really important, it's something to design properly to be able
> to plug those loadable palettes into QColorDialog.
> 
> Regards.