Review Request 114184: Remove everything in kstyle that is not about KDE integration
Hugo Pereira Da Costa
hugo at oxygen-icons.org
Fri Nov 29 14:50:18 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114184/#review44804
-----------------------------------------------------------
Looks good to me !
I'll try the patch some time this week-end, making oxygen derive from it again (instead of qcommonstyle), and trying to remove the duplicated code.
Will keep you posted.
- Hugo Pereira Da Costa
On Nov. 29, 2013, 1:28 p.m., Àlex Fiestas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114184/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2013, 1:28 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Removed everything from KStyle that is NOT about integrating with KDE.
>
>
> Diffs
> -----
>
> tier4/frameworkintegration/src/kstyle/kstyle.h 4c83509
> tier4/frameworkintegration/src/kstyle/kstyle.cpp 626d2a9
>
> Diff: http://git.reviewboard.kde.org/r/114184/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Àlex Fiestas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131129/ba494fba/attachment.html>
More information about the Kde-frameworks-devel
mailing list