Review Request 114184: Remove everything in kstyle that is not about KDE integration

[Àlex Fiestas]

> On Nov. 29, 2013, 8:52 a.m., Kevin Ottens wrote:
> > tier4/frameworkintegration/src/kstyle/kstyle.h, line 1518
> > <http://git.reviewboard.kde.org/r/114184/diff/2/?file=220988#file220988line1518>
> >
> >     If you use Q_DECL_OVERRIDE, no need to repeat the virtual (applies to most of the methods in here).

I do like virtual, it is more syntax sugar and C++ developers are more use to it than to Q_DECL_OVERRIDE. I'd like to keep it but if you really want I can remove it.


> On Nov. 29, 2013, 8:52 a.m., Kevin Ottens wrote:
> > tier4/frameworkintegration/src/kstyle/kstyle.h, line 1523
> > <http://git.reviewboard.kde.org/r/114184/diff/2/?file=220988#file220988line1523>
> >
> >     Hmmm, I don't get that one... Which warning did you get? Because of the QApplication and QPalette overloads?

Yes


> On Nov. 29, 2013, 8:52 a.m., Kevin Ottens wrote:
> > tier4/frameworkintegration/src/kstyle/kstyle.cpp, line 373
> > <http://git.reviewboard.kde.org/r/114184/diff/2/?file=220989#file220989line373>
> >
> >     Is it me or it's not needed anymore since the eventFilter method is gone? (not that it was doing anything meaningful previously).
> >     
> >     Even more so as you removed the removeEventFilter line from unpolish().

Yeah, I removed all of this but forgot this one :/


- Àlex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114184/#review44770
-----------------------------------------------------------


On Nov. 28, 2013, 6:20 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114184/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2013, 6:20 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Removed everything from KStyle that is NOT about integrating with KDE.
> 
> 
> Diffs
> -----
> 
>   tier4/frameworkintegration/src/kstyle/kstyle.h 4c83509 
>   tier4/frameworkintegration/src/kstyle/kstyle.cpp 626d2a9 
> 
> Diff: http://git.reviewboard.kde.org/r/114184/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131129/1e0f5eaf/attachment-0001.html>