Review Request 114184: Remove everything in kstyle that is not about KDE integration

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114184/#review44741
-----------------------------------------------------------



tier4/frameworkintegration/src/kstyle/kstyle.h
<http://git.reviewboard.kde.org/r/114184/#comment31976>

    This doesn't really make sense.  That should probably say "QStyle" rather than "KStyle".
    
    Actually, I would phrase it
    "Provides integration with KDE Plasma Workspace settings for Qt styles", or something like that.



tier4/frameworkintegration/src/kstyle/kstyle.h
<http://git.reviewboard.kde.org/r/114184/#comment31978>

    We don't care about implementation here; talk about how to use it and why.  Something like "Derive your Qt style from KStyle to automatically inherit various settings from the KDE Plasma Workspace, providing a consistent user experience.  For example, this will ensure a consistent single-click or double-click activation setting, and the use of standard themed icons".



tier4/frameworkintegration/src/kstyle/kstyle.cpp
<http://git.reviewboard.kde.org/r/114184/#comment31977>

    KStylePrivate does nothing.  Remove the definition, and set d to 0 in the constructor.


- Alex Merry


On Nov. 28, 2013, 6:20 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114184/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2013, 6:20 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Removed everything from KStyle that is NOT about integrating with KDE.
> 
> 
> Diffs
> -----
> 
>   tier4/frameworkintegration/src/kstyle/kstyle.h 4c83509 
>   tier4/frameworkintegration/src/kstyle/kstyle.cpp 626d2a9 
> 
> Diff: http://git.reviewboard.kde.org/r/114184/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131128/4b690fd3/attachment-0001.html>