Review Request 114182: Add Kf5 prefix for libs, eg. libKf5Foo

[Martin Gräßlin]

> On Nov. 28, 2013, 4:43 p.m., Kevin Ottens wrote:
> > Looks fine to me. Makes me wonder if we want to drop the K for the target name "KF5::ConfigCore"? Just like Qt5Widgets becomes Qt5::Widgets...
> 
> Martin Klapetek wrote:
>     Can do. Imho it makes sense but I'll wait for some other opinions so I don't have to redo/undo all of it then. Will try to still do it by tonight.
> 
> Martin Klapetek wrote:
>     No comments on dropping the K? I'm about to do this...

+1


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114182/#review44703
-----------------------------------------------------------


On Nov. 28, 2013, 2:46 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114182/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2013, 2:46 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This is just one framework - KConfig - if this is the proper way to do this, I'll update this review with all frameworks updated to this.
> 
> 
> Diffs
> -----
> 
>   tier1/kconfig/autotests/CMakeLists.txt cc2626b 
>   tier1/kconfig/src/core/CMakeLists.txt c8a4842 
>   tier1/kconfig/src/gui/CMakeLists.txt b677d03 
>   tier1/kconfig/src/kconf_update/CMakeLists.txt 69668bc 
> 
> Diff: http://git.reviewboard.kde.org/r/114182/diff/
> 
> 
> Testing
> -------
> 
> Builds.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131128/499ad551/attachment.html>