Review Request 114158: Use Sonnet::SpellCheckDecorator internally in KTextEdit

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114158/
-----------------------------------------------------------

(Updated Nov. 28, 2013, 4:28 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
-------

Use Sonnet::Decorator internally in KTextEdit

In order to keep api compatibility we create a custom Sonnet::Decorator and proxy the virtual methods.
The spellcheckdecorator event filter intercepts the context menu for mispelled words our implementation will only be called for all other context menu events.


Diffs
-----

  tier3/ktextwidgets/src/widgets/ktextedit.h 2086607 
  tier3/ktextwidgets/src/widgets/ktextedit.cpp f5d0331 

Diff: http://git.reviewboard.kde.org/r/114158/diff/


Testing
-------

I still have something wrong with my spell checker in KF5: 
Aurélien tested for me, there appear to be some issues, such as not showing a context menu until a language is set, but this seems to be independent from this patch.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131128/606efa0e/attachment.html>