Review Request 114038: Integrate KAboutData and QCommandLineParser

Aleix Pol Gonzalez aleixpol at kde.org
Mon Nov 25 16:26:30 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114038/
-----------------------------------------------------------

(Updated Nov. 25, 2013, 4:26 p.m.)


Review request for KDE Frameworks.


Changes
-------

adopted david's suggestions


Repository: kdelibs


Description
-------

There was a functionality regression from KDE4 where every application would get an --authors and a --license argument automatically.

This patch makes it possible to let KAboutData configure QCommandLineParser to add the missing arguments and react if those are required.


Diffs (updated)
-----

  tier1/kcoreaddons/src/lib/kaboutdata.h b56832c 
  tier1/kcoreaddons/src/lib/kaboutdata.cpp 5ea8862 
  tier3/kservice/src/kbuildsycoca/CMakeLists.txt 52b46c4 
  tier3/kservice/src/kbuildsycoca/kbuildsycoca.cpp 05019ad 

Diff: http://git.reviewboard.kde.org/r/114038/diff/


Testing
-------

Made kbuildsycoca5 use it and made sure it works.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131125/28312fc5/attachment.html>


More information about the Kde-frameworks-devel mailing list