Review Request 114111: Fix KIconThemes standalone build

[Aurélien Gâteau]

> On Nov. 25, 2013, 4:49 p.m., Maarten De Meyer wrote:
> > Are you sure this is needed? KConfigWidgets already includes KGuiAddons and KIconThemes doesn't link with KGuiAddons directly.
> > You say it "complains" so you are still able to build?
> > Next version of CMake should fix this.
> 
> Bhushan Shah wrote:
>     No I am not able to run cmake, it fails..
> 
> Alex Merry wrote:
>     Yeah, this is apparently a known bug with current versions of CMake (pre-3.0.0).  But we have to support 2.8.12, so we need to include the private dependencies of the things we link to.
> 
> Bhushan Shah wrote:
>     @Alex Merry so ship it?
> 
> Alex Merry wrote:
>     Although... KGuiAddons is a *public* dependency of KConfigWidgets, so the KConfigWidgetsConfig.cmake file should include KGuiAddons.  So I'm surprised this is needed.

Looking at tier3/kconfigwidgets/src/CMakeLists.txt, KGuiAddons is a private dependency of KConfigWidgets, so it should not be listed in KConfigWidgetsConfig.cmake.

Regarding the patch, we investigated those issues with David Faure yesterday: it appears the dependency problem only happens when building frameworks non standalone: if you rebuild kconfigwidgets in standalone mode, then kiconthemes should build without needing this patch. This means we may be able to avoid adding dependencies, so I would refrain from adding more for now.


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114111/#review44430
-----------------------------------------------------------


On Nov. 25, 2013, 4:32 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114111/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2013, 4:32 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> summary ^
> 
> 
> it complains about KGuiAddons in cmake. it fixes this..
> 
> 
> Diffs
> -----
> 
>   tier3/kiconthemes/CMakeLists.txt d1191d1 
> 
> Diff: http://git.reviewboard.kde.org/r/114111/diff/
> 
> 
> Testing
> -------
> 
> compiles, links, installs.
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131125/170b9221/attachment.html>