Review Request 114111: Fix KIconThemes standalone build

Maarten De Meyer de.meyer.maarten at gmail.com
Mon Nov 25 15:49:38 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114111/#review44430
-----------------------------------------------------------


Are you sure this is needed? KConfigWidgets already includes KGuiAddons and KIconThemes doesn't link with KGuiAddons directly.
You say it "complains" so you are still able to build?
Next version of CMake should fix this.

- Maarten De Meyer


On Nov. 25, 2013, 3:32 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114111/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2013, 3:32 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> summary ^
> 
> 
> it complains about KGuiAddons in cmake. it fixes this..
> 
> 
> Diffs
> -----
> 
>   tier3/kiconthemes/CMakeLists.txt d1191d1 
> 
> Diff: http://git.reviewboard.kde.org/r/114111/diff/
> 
> 
> Testing
> -------
> 
> compiles, links, installs.
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131125/0da803a8/attachment.html>


More information about the Kde-frameworks-devel mailing list