Review Request 113503: make dbus dependency optional in JobWidgets

Sune Vuorela kde at pusling.com
Mon Nov 25 13:56:42 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113503/
-----------------------------------------------------------

(Updated Nov. 25, 2013, 1:56 p.m.)


Status
------

This change has been discarded.


Review request for KDE Frameworks, kdelibs and Stephen Kelly.


Repository: kdelibs


Description
-------

Make dbus dependency optional in JobWidgets

Many don't have dbus available on all platforms, especially windows, but JobWidgets is very much useful without it.


Diffs
-----

  tier2/kjobwidgets/CMakeLists.txt ca53024 
  tier2/kjobwidgets/src/CMakeLists.txt 0a575a6 
  tier2/kjobwidgets/src/config-kjobwidgets.h.cmake 35b64a2 
  tier2/kjobwidgets/tests/kjobtrackerstest.cpp 7a61407 

Diff: http://git.reviewboard.kde.org/r/113503/diff/


Testing
-------

build tested on windows without dbus. not yet tested on other platforms


Thanks,

Sune Vuorela

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131125/b812829f/attachment.html>


More information about the Kde-frameworks-devel mailing list