Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros
Kevin Ottens
ervin at kde.org
Mon Nov 25 13:55:18 UTC 2013
> On Nov. 18, 2013, 5 p.m., Kevin Ottens wrote:
> > After discussion on the mailing list, let's get that in for the time being. It is to be considered as a temporary solution and will be removed when CMake 3 will be available.
Please push it ASAP, we need to tie up loose ends NOW.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112785/#review43904
-----------------------------------------------------------
On Sept. 17, 2013, 7:56 p.m., Jeremy Whiting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112785/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2013, 7:56 p.m.)
>
>
> Review request for KDE Frameworks and Alexander Neundorf.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> It builds and installs, but doesn't seem to be usable from within kdelibs, i.e. ki18n_wrap_ui in knewstuff/src/CMakeLists.txt fails with this. I suspect one more thing is needed to make it work from within kdelibs builds.
>
>
> Diffs
> -----
>
> tier2/ki18n/CMakeLists.txt d0ed448
> tier2/ki18n/KI18nConfig.cmake.in 18b6e2f
> tier2/ki18n/cmake/KI18NMacros.cmake PRE-CREATION
> tier2/ki18n/cmake/ki18nuic.cmake PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/112785/diff/
>
>
> Testing
> -------
>
> Builds and installs into PREFIX/lib64/cmake/KI18N next to KI18nConfig.cmake
>
>
> Thanks,
>
> Jeremy Whiting
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131125/ebf8ac62/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list