Review Request 112880: Added KColorSchemeToken class.
Kevin Ottens
ervin at kde.org
Mon Nov 25 13:48:41 UTC 2013
> On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote:
> > To get in this patch would benefit from being based on the frameworks branch and go into kdeclarative.
>
> Kevin Ottens wrote:
> Any chance for an update?
>
> Denis Kuplyakov wrote:
> Yes I will finish it, when have time. There are many pre-exams in university.
Any news? we need to get in or discard all the old patches now.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/#review42069
-----------------------------------------------------------
On Oct. 6, 2013, 7:24 p.m., Denis Kuplyakov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112880/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2013, 7:24 p.m.)
>
>
> Review request for KDE Frameworks and kdelibs.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> It is wrapper to access KColorScheme's methods from QML code.
> Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them accessible from QML code.
>
> As it will be accepted, QML-clone of KgPopupItem will be posted for review to libkdegames, as it uses it to access KDE's color theme.
>
> More info:
> * search for "KDE theme colors API for QML" thread at kdelibs and kdegames mailinglists *
>
>
> Diffs
> -----
>
> kdeui/CMakeLists.txt b439e04
> includes/CMakeLists.txt cdf0143
> includes/KColorSchemeToken PRE-CREATION
> kdeui/colors/kcolorscheme.h 17570fd
> kdeui/colors/kcolorscheme.cpp a6650ac
> kdeui/colors/kcolorschemetoken.h PRE-CREATION
> kdeui/colors/kcolorschemetoken.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/112880/diff/
>
>
> Testing
> -------
>
> I've tested it with KReversi's deniskup/gsoc2013/newdesign branch.
>
>
> Thanks,
>
> Denis Kuplyakov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131125/6f7e1ca6/attachment.html>
More information about the Kde-frameworks-devel
mailing list