Review Request 113996: Install needed private headers for FrameworksIntegration

Aleix Pol Gonzalez aleixpol at kde.org
Mon Nov 25 12:26:21 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113996/
-----------------------------------------------------------

(Updated Nov. 25, 2013, 12:26 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
-------

There are 2 headers to install:
- kmessageboxnotifyinterface.h: It's an interface, it's obvious to me that it should be installed
- kiconengine_p.h: I have no idea, but it's still needed. (note it's also needed by kicon.cpp in kde4support).


Diffs
-----

  tier1/kwidgetsaddons/src/CMakeLists.txt 9223ccf 
  tier3/kiconthemes/src/CMakeLists.txt 4b3c978 
  tier3/kiconthemes/src/kiconengine_p.h  

Diff: http://git.reviewboard.kde.org/r/113996/diff/


Testing
-------

FrameworksIntegration builds modularized, monolithic kdelibs still build as well.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131125/42393a78/attachment.html>


More information about the Kde-frameworks-devel mailing list