Review Request 114044: Remove unused dependencies in kcoreaddons

David Faure faure at kde.org
Sun Nov 24 19:45:14 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114044/#review44347
-----------------------------------------------------------

Ship it!


Probably historical. Well spotted!

- David Faure


On Nov. 22, 2013, 6:53 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114044/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2013, 6:53 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> I cannot find any source reference to QtConcurrent and QtNetwork, so remove it.
> 
> 
> Diffs
> -----
> 
>   tier1/kcoreaddons/CMakeLists.txt d797f173cbc78cf7e01ee60c35e3e7a53af69621 
>   tier1/kcoreaddons/autotests/CMakeLists.txt 19ea80a909b2af7cea0177b3a3c6c21d342ee2d0 
>   tier1/kcoreaddons/tests/CMakeLists.txt 1df24743921206e7b0a3690c3047d0fc3fcec651 
> 
> Diff: http://git.reviewboard.kde.org/r/114044/diff/
> 
> 
> Testing
> -------
> 
> Builds with QtConcurrent and QtNetwork packages not present.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131124/6311d19b/attachment.html>


More information about the Kde-frameworks-devel mailing list