Review Request 114038: Integrate KAboutData and QCommandLineParser

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114038/#review44296
-----------------------------------------------------------


Great idea, thanks.


tier1/kcoreaddons/src/lib/kaboutdata.h
<http://git.reviewboard.kde.org/r/114038/#comment31700>

    Comment from Aurélien: this should be a pointer rather than a reference. As explained in the Qt API recommandations, this makes it visible in the calling code that the parser object will be modified.
    
    
    (coding style: the & or the * should be after the space)



tier1/kcoreaddons/src/lib/kaboutdata.cpp
<http://git.reviewboard.kde.org/r/114038/#comment31698>

    space after "if" (everywhere)



tier1/kcoreaddons/src/lib/kaboutdata.cpp
<http://git.reviewboard.kde.org/r/114038/#comment31701>

    (LOL, most likely someone forgot to call addAuthor, but OK :)
    
    
    Wrong usage of tr() (this will use QCoreApplication as context). Use tr() (might need Q_DECLARE_TR_FUNCTIONS in the header, since this isn't a QObject), or use translate() with a context, like in the example program in this patch.



tier3/kservice/src/kbuildsycoca/kbuildsycoca.cpp
<http://git.reviewboard.kde.org/r/114038/#comment31702>

    This should be moved to *after* the QCoreApplication constructor. That's the difference with K4AboutData+ki18n which had to run before the app ctor.
    
    
    You could change the variable name to be more readable than "d", while at it :)


- David Faure


On Nov. 22, 2013, 6:07 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114038/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2013, 6:07 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> There was a functionality regression from KDE4 where every application would get an --authors and a --license argument automatically.
> 
> This patch makes it possible to let KAboutData configure QCommandLineParser to add the missing arguments and react if those are required.
> 
> 
> Diffs
> -----
> 
>   tier1/kcoreaddons/src/lib/kaboutdata.h f9dee8e 
>   tier1/kcoreaddons/src/lib/kaboutdata.cpp 5ea8862 
>   tier3/kservice/src/kbuildsycoca/CMakeLists.txt 52b46c4 
>   tier3/kservice/src/kbuildsycoca/kbuildsycoca.cpp 05019ad 
> 
> Diff: http://git.reviewboard.kde.org/r/114038/diff/
> 
> 
> Testing
> -------
> 
> Made kbuildsycoca5 use it and made sure it works.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131124/7ab1ee79/attachment-0001.html>