Review Request 114052: Skip tests which need a window manager running

[Ben Cooksley]

> On Nov. 23, 2013, 4:19 p.m., Albert Astals Cid wrote:
> > Have you talked to with the build.kde.org guys to see if we can get such a window manager running?
> 
> Martin Gräßlin wrote:
>     [12:21] <mgraesslin> bcooksley: fyi https://git.reviewboard.kde.org/r/114052/
>     [12:22] <bcooksley> mgraesslin: oki, looks fine to me 
>     [12:22] <bcooksley> not the best from a coverage POV obviously
>     [12:22] <bcooksley> but not much else we can do short of using a WM provided by another project
>     [12:22] <bcooksley> (like if X itself had one)
>     [12:23] <bcooksley> (adding support to get such a WM started wouldn't be much effort at all)
>     [12:25] <mgraesslin> well maybe use something very simple which is netwm compliant
>     [12:25] <svuorela> is twm netwm compliant ?
>     [12:25] <mgraesslin> I don't think so
>     [12:25] <mgraesslin> isn't twm requiring you to manually place the windows?
>     [12:26] <svuorela> else flux/open/blackbox according to wikipedias
>

I've adjusted the CI system to ensure Openbox is run before tests are executed, which fixes this test.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114052/#review44270
-----------------------------------------------------------


On Nov. 23, 2013, 11:18 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114052/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2013, 11:18 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Fixes unit test failure in Jenkins due to no netwm-compliant window manager running.
> 
> 
> Diffs
> -----
> 
>   tier1/kwindowsystem/autotests/kwindowsystemx11test.cpp c9784b1 
> 
> Diff: http://git.reviewboard.kde.org/r/114052/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131123/a3f794c0/attachment.html>