Review Request 113962: Fixing regression in KWindowSystem_X11

[Martin Gräßlin]

> On Nov. 22, 2013, 5:56 p.m., Kevin Ottens wrote:
> > If we believe jenkins, the test you introduced fails. :-)
> 
> Martin Gräßlin wrote:
>     no I don't believe Jenkins. It works on my machine ;-)
>     
>     I'll try to contact Ben to see what's going on there. Maybe the test is not working properly when using Xvfb.

I figured out why the test is failing: it needs a running netwm-compliant window manager.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113962/#review44221
-----------------------------------------------------------


On Nov. 21, 2013, 6:35 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113962/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2013, 6:35 p.m.)
> 
> 
> Review request for KDE Frameworks and Eike Hein.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> KWindowSystemPrivate was not adjusted to the changes in NETRootInfo.
> Fix comes with a unit test.
> 
> 
> Diffs
> -----
> 
>   tier1/kwindowsystem/src/kwindowsystem_x11.cpp 2bc2ddc 
>   tier1/kwindowsystem/autotests/kwindowsystemx11test.cpp PRE-CREATION 
>   tier1/kwindowsystem/autotests/CMakeLists.txt 27451b7 
> 
> Diff: http://git.reviewboard.kde.org/r/113962/diff/
> 
> 
> Testing
> -------
> 
> See unit test and also libtaskmanager (which got broken by this regression)
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131123/e9c2ab72/attachment.html>