Review Request 114003: Install private headers needed by kde4support

Aleix Pol Gonzalez aleixpol at kde.org
Fri Nov 22 18:23:59 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114003/
-----------------------------------------------------------

(Updated Nov. 22, 2013, 6:23 p.m.)


Review request for KDE Frameworks.


Changes
-------

Remove kmimetyperesolver.cpp so that we don't need to install defaultviewadapter_p.h.

Now we're not installing any new header files. \o/


Repository: kdelibs


Description
-------

defaultviewadapter_p.h: Needed by tier4/kde4support/src/kio/kmimetyperesolver.cpp
kfiletreeview_p.h: Needed by tier4/kde4support/src/kio/kdirselectdialog.cpp


Diffs (updated)
-----

  tier3/kio/src/filewidgets/CMakeLists.txt 13a3918 
  tier3/kio/src/filewidgets/kfiletreeview.cpp  
  tier3/kio/src/filewidgets/kfiletreeview_p.h d8a8aa6 
  tier3/kio/tests/CMakeLists.txt 7086285 
  tier3/kio/tests/kfiletreeviewtest.h  
  tier3/kio/tests/kfiletreeviewtest.cpp  
  tier4/kde4support/src/CMakeLists.txt 9a731fd 
  tier4/kde4support/src/kio/kmimetyperesolver.h 515dcfb 
  tier4/kde4support/src/kio/kmimetyperesolver.cpp 69e64fd 
  tier4/kde4support/tests/CMakeLists.txt 7705381 

Diff: http://git.reviewboard.kde.org/r/114003/diff/


Testing
-------

Builds, tests still pass.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131122/68645ee5/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list