Review Request 114003: Install private headers needed by kde4support
Kevin Ottens
ervin at kde.org
Thu Nov 21 16:52:50 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114003/#review44135
-----------------------------------------------------------
Don't we have better solutions than installing random private headers? Gives me an uneasy feeling.
- Kevin Ottens
On Nov. 21, 2013, 4:23 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114003/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2013, 4:23 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> defaultviewadapter_p.h: Needed by tier4/kde4support/src/kio/kmimetyperesolver.cpp
> kfiletreeview_p.h: Needed by tier4/kde4support/src/kio/kdirselectdialog.cpp
>
>
> Diffs
> -----
>
> tier3/kio/src/filewidgets/CMakeLists.txt 13a3918
>
> Diff: http://git.reviewboard.kde.org/r/114003/diff/
>
>
> Testing
> -------
>
> Builds, tests still pass.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131121/ac1890c9/attachment.html>
More information about the Kde-frameworks-devel
mailing list