Review Request 113975: Make some KSSL files public API

Kevin Ottens ervin at kde.org
Thu Nov 21 16:51:50 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113975/#review44133
-----------------------------------------------------------


I'd give a ship it, but I'd like David to take a look at it.

- Kevin Ottens


On Nov. 20, 2013, 7:02 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113975/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2013, 7:02 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> I was trying to get KHTML to build standalone, the only missing part I have is these files need to be public API and in the correct namespace.
> 
> 
> Diffs
> -----
> 
>   tier3/kio/src/core/CMakeLists.txt 1944435 
> 
> Diff: http://git.reviewboard.kde.org/r/113975/diff/
> 
> 
> Testing
> -------
> 
> Everything still builds.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131121/315d0cd0/attachment.html>


More information about the Kde-frameworks-devel mailing list