Review Request 113968: Make KFileAudioPreview use its own config group

Kevin Ottens ervin at kde.org
Thu Nov 21 16:50:13 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113968/#review44132
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On Nov. 20, 2013, 11:36 a.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113968/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2013, 11:36 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> One last thing needed before I move this to kde-workspace:
> 
> 
> Make KFileAudioPreview use its own config group
> 
> Previously, it was using "KFileDialog Settings", and this string was
> obtained from an internal KIO header (which breaks standalone builds).
> 
> 
> Diffs
> -----
> 
>   staging/kmediaplayer/src/kfileaudiopreview/kfileaudiopreview.cpp 04efb24 
> 
> Diff: http://git.reviewboard.kde.org/r/113968/diff/
> 
> 
> Testing
> -------
> 
> Builds.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131121/65f3a8b1/attachment.html>


More information about the Kde-frameworks-devel mailing list