Review Request 113949: Workaround for dependency issues when generating .json from .desktop files

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113949/#review44130
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On Nov. 19, 2013, 6:19 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113949/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2013, 6:19 p.m.)
> 
> 
> Review request for KDE Frameworks and Sebastian Kügler.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> There is currently no way to declare a target as a dependency of the automoc
> target, so it is not possible to ensure .json files are generated from .desktop
> files before moc is run. To work around this, generate .json files at configure
> time.
> 
> This is a workaround because it means changes to .desktop files won't be applied
> to .json files when building, one will need to re-run cmake.
> 
> This changes adds a test to ensure the CMake macro works well. It is declared as
> an external project because it needs desktoptojson to be installed to work
> correctly.
> 
> 
> Diffs
> -----
> 
>   tier3/kservice/KServiceMacros.cmake d5b30ce 
>   tier3/kservice/src/desktoptojson/CMakeLists.txt 9dc8635 
>   tier3/kservice/tests/kservicetojsontest/CMakeLists.txt PRE-CREATION 
>   tier3/kservice/tests/kservicetojsontest/README PRE-CREATION 
>   tier3/kservice/tests/kservicetojsontest/dummy-service.desktop PRE-CREATION 
>   tier3/kservice/tests/kservicetojsontest/dummyplugin.h PRE-CREATION 
>   tier3/kservice/tests/kservicetojsontest/dummyplugin.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113949/diff/
> 
> 
> Testing
> -------
> 
> kdelibs still builds, repositories such as kde-runtime and kde-workspace build as well.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131121/ef3ad6aa/attachment.html>