Review Request 113996: Install needed private headers for FrameworksIntegration

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113996/#review44125
-----------------------------------------------------------



tier3/kiconthemes/src/CMakeLists.txt
<http://git.reviewboard.kde.org/r/113996/#comment31617>

    Actually makes no sense anymore to keep it private IMO. Please rename it in the process to make it a proper public header.


- Kevin Ottens


On Nov. 21, 2013, 12:29 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113996/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2013, 12:29 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> There are 2 headers to install:
> - kmessageboxnotifyinterface.h: It's an interface, it's obvious to me that it should be installed
> - kiconengine_p.h: I have no idea, but it's still needed. (note it's also needed by kicon.cpp in kde4support).
> 
> 
> Diffs
> -----
> 
>   tier1/kwidgetsaddons/src/CMakeLists.txt 9223ccf 
>   tier3/kiconthemes/src/CMakeLists.txt 4b3c978 
> 
> Diff: http://git.reviewboard.kde.org/r/113996/diff/
> 
> 
> Testing
> -------
> 
> FrameworksIntegration builds modularized, monolithic kdelibs still build as well.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131121/fca832f8/attachment.html>