Review Request 113996: Install needed private headers for FrameworksIntegration
Aurélien Gâteau
agateau at kde.org
Thu Nov 21 16:21:56 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113996/#review44120
-----------------------------------------------------------
Ship it!
Ship It!
- Aurélien Gâteau
On Nov. 21, 2013, 1:29 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113996/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2013, 1:29 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> There are 2 headers to install:
> - kmessageboxnotifyinterface.h: It's an interface, it's obvious to me that it should be installed
> - kiconengine_p.h: I have no idea, but it's still needed. (note it's also needed by kicon.cpp in kde4support).
>
>
> Diffs
> -----
>
> tier1/kwidgetsaddons/src/CMakeLists.txt 9223ccf
> tier3/kiconthemes/src/CMakeLists.txt 4b3c978
>
> Diff: http://git.reviewboard.kde.org/r/113996/diff/
>
>
> Testing
> -------
>
> FrameworksIntegration builds modularized, monolithic kdelibs still build as well.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131121/670edacb/attachment.html>
More information about the Kde-frameworks-devel
mailing list