Review Request 113970: KConfigDialog: Guard against editing buttons that do not exist.

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113970/
-----------------------------------------------------------

(Updated Nov. 20, 2013, 4:55 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
-------

KConfigDialog: Guard against editing buttons that do not exist.

ButtonBox is public inside KPageDialog which means any other class can
call setButtons() on it.

KConfigDialog can not reliably know that certain buttons exist, and
should guard appropriately.

This fixes a crash in systemsettings in Plasma2


Diffs
-----

  tier3/kconfigwidgets/src/kconfigdialog.cpp 23ed3ee 

Diff: http://git.reviewboard.kde.org/r/113970/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131120/e4d9cbb0/attachment-0001.html>