Review Request 113935: Clean up FindOpenEXR.cmake and move to tier1/kguiaddons/cmake
Alex Merry
kde at randomguy3.me.uk
Tue Nov 19 15:27:25 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113935/
-----------------------------------------------------------
(Updated Nov. 19, 2013, 3:27 p.m.)
Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly.
Changes
-------
Use "mode 2" form of find_package_handle_standard_args. Also throw in a version check, in case we start depending on a particular version.
Repository: kdelibs
Description
-------
Clean up FindOpenEXR.cmake and move to tier1/kguiaddons/cmake
Only kguiaddons uses it for now; it can be moved to ECM later if there
is another user.
This replaces https://git.reviewboard.kde.org/r/113834/ and https://git.reviewboard.kde.org/r/113828/
Diffs (updated)
-----
tier1/kguiaddons/CMakeLists.txt 227718a383ba8598fcfb24549f9dd2a6a3547a8a
tier1/kguiaddons/cmake/FindOpenEXR.cmake PRE-CREATION
tier1/kguiaddons/src/plugins/imageformats/CMakeLists.txt 6637a16711d21c2a180914ad2530e3ac85b14a22
tier4/kde4support/cmake/modules/CMakeLists.txt 2911e70f3dd253ab552bfd228a25b3ae38452218
tier4/kde4support/cmake/modules/FindOpenEXR.cmake 93b05dd999c12605973c1a0a2020a72aece88b65
Diff: http://git.reviewboard.kde.org/r/113935/diff/
Testing
-------
OpenEXR is found, both on an existing build of kdelibs-frameworks and on a clean run of CMake. Still builds and links properly.
Thanks,
Alex Merry
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131119/4dde8669/attachment.html>
More information about the Kde-frameworks-devel
mailing list