Review Request 113935: Clean up FindOpenEXR.cmake and move to tier1/kguiaddons/cmake

[Stephen Kelly]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113935/#review43932
-----------------------------------------------------------



tier1/kguiaddons/cmake/FindOpenEXR.cmake
<http://git.reviewboard.kde.org/r/113935/#comment31548>

    Please use ExactCase instead. As this is used internally only, no need to set the uppercase versions for compatibility.



tier1/kguiaddons/cmake/FindOpenEXR.cmake
<http://git.reviewboard.kde.org/r/113935/#comment31549>

    The API is the _DIRS variable. Keep setting the _DIR variable as-is, but add it to a _DIRS variable afterward.


- Stephen Kelly


On Nov. 19, 2013, 10:29 a.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113935/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2013, 10:29 a.m.)
> 
> 
> Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Clean up FindOpenEXR.cmake and move to tier1/kguiaddons/cmake
> 
> Only kguiaddons uses it for now; it can be moved to ECM later if there
> is another user.
> 
> 
> This replaces https://git.reviewboard.kde.org/r/113834/ and https://git.reviewboard.kde.org/r/113828/
> 
> 
> Diffs
> -----
> 
>   tier1/kguiaddons/CMakeLists.txt 227718a 
>   tier1/kguiaddons/cmake/FindOpenEXR.cmake PRE-CREATION 
>   tier1/kguiaddons/src/plugins/imageformats/CMakeLists.txt 6637a16 
>   tier4/kde4support/cmake/modules/CMakeLists.txt 2911e70 
>   tier4/kde4support/cmake/modules/FindOpenEXR.cmake 93b05dd 
> 
> Diff: http://git.reviewboard.kde.org/r/113935/diff/
> 
> 
> Testing
> -------
> 
> OpenEXR is found, both on an existing build of kdelibs-frameworks and on a clean run of CMake.  Still builds and links properly.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131119/63f4cfd0/attachment-0001.html>