Review Request 113685: New KColorSchemeManager to support changing color scheme in app

[Albert Astals Cid]

> On Nov. 15, 2013, 7:42 p.m., Kevin Ottens wrote:
> > tier3/kconfigwidgets/src/kcolorschememanager.cpp, line 124
> > <http://git.reviewboard.kde.org/r/113685/diff/3/?file=213999#file213999line124>
> >
> >     Would make sense to change the lambda so that you'd pass 16 and 24 instead. It feels kinda weird otherwise. :-)
> >     
> >     You can still do (size / 2) - 1 in the lambda to prepare for the fillRect calls.
> 
> Albert Astals Cid wrote:
>     What about the color palettes vs theme colors issue?
> 
> Martin Gräßlin wrote:
>     There is no issue at all about color palettes vs theme colors. It's just the color schemes it operates on.
> 
> Albert Astals Cid wrote:
>     So you're saying Boud's and Christoph comments are wrong?
> 
> Martin Gräßlin wrote:
>     not at all. That are two different beast which just have the same file ending. The palettes are installed to **/colors/, the color-schemes to **/color-schemes/. This class only looks for files in color-schemes/, so that the palettes have the same file ending doesn't matter.

Ok, point taken, so back to the "should we i18n this?" Yes, we should. This .colors file looks .desktop like so just by adding a ExtraDesktop.sh file (see kwin for example) and then using KConfig should do it. I guess we should probably take the discussion somewhere else?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113685/#review43755
-----------------------------------------------------------


On Nov. 18, 2013, 8:44 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113685/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2013, 8:44 a.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Gilles Caulier, and Boudewijn Rempt.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This class is inspired by functionality offered by e.g. Krita and
> Digikam to allow the user to select a different color scheme for the
> application.
>     
> This manager simplifies this task and also ensures that the required
> property on QApplication is set, so that a QStyle can pass the scheme
> to the window manager/compositor for the windows of the application.
> 
> @boud and @cgilles: please have a look whether this approach is sufficient for your usecases in digkam and Krita.
> 
> 
> Diffs
> -----
> 
>   tier3/kconfigwidgets/tests/kcolorschemedemo.cpp PRE-CREATION 
>   tier3/kconfigwidgets/src/CMakeLists.txt 36ffca8 
>   tier3/kconfigwidgets/src/kcolorschememanager.h PRE-CREATION 
>   tier3/kconfigwidgets/src/kcolorschememanager.cpp PRE-CREATION 
>   tier3/kconfigwidgets/src/kcolorschememanager_p.h PRE-CREATION 
>   tier3/kconfigwidgets/tests/CMakeLists.txt f66dc32 
> 
> Diff: http://git.reviewboard.kde.org/r/113685/diff/
> 
> 
> Testing
> -------
> 
> see demo application
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131118/4ee90c59/attachment.html>