Review Request 113883: Rename translation catalogue kfileaudiopreview4 to kfileaudiopreview

[Alex Merry]

> On Nov. 15, 2013, 12:32 p.m., Aleix Pol Gonzalez wrote:
> > Why do you need to drop the version? In similar cases we've been bumping to 5...
> 
> Kevin Ottens wrote:
>     Yeah I'm surprised as well... OTOH that's a regular library, we don't mention the version name for those (unlike for executables like kded)
> 
> Albert Astals Cid wrote:
>     FWIW This is not about library versioning but about the po catalog naming.
> 
> Alex Merry wrote:
>     I have no preference either way, only that it shouldn't be "4".
> 
> Chusslove Illich wrote:
>     >> [: Albert Astals Cid :]
>     >> FWIW This is not about library versioning but about the po catalog
>     >> naming.
>     >
>     > [: Alex Merry :]
>     > I have no preference either way, only that it shouldn't be "4".
>     
>     The reason why that "4" appeared was to enable kdelibs from KDE 3 and KDE 4
>     to be installed in the same path. So the action now depends on whether the
>     same should be possible for KDE 3 kdelibs and KF5. If not, "4" can be
>     dropped, if yes, it must be bumped to "5".
>

So I've changed it to include "5", since that seems like the less contentious solution.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113883/#review43729
-----------------------------------------------------------


On Nov. 15, 2013, 9:10 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113883/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2013, 9:10 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Rename translation catalogue kfileaudiopreview4 to kfileaudiopreview
> 
> 
> Diffs
> -----
> 
>   staging/kmediaplayer/src/kfileaudiopreview/Messages.sh 71c7067 
>   staging/kmediaplayer/src/kfileaudiopreview/kfileaudiopreview.cpp 04efb24 
>   staging/kmediaplayer/src/kfileaudiopreview/mediacontrols_p.h bb36ab1 
> 
> Diff: http://git.reviewboard.kde.org/r/113883/diff/
> 
> 
> Testing
> -------
> 
> Builds.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131118/08ccc49f/attachment.html>