Review Request 113881: Standardise d-pointer classes of kmediaplayer

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113881/
-----------------------------------------------------------

(Updated Nov. 15, 2013, 9:03 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
-------

Standardise d-pointer classes of kmediaplayer

Use "class Private" instead of "struct Data", for consistency with other
KDE software, and move all private members to those classes.


Diffs
-----

  staging/kmediaplayer/src/kmediaplayer/view.h 3bc849f5d93b5bb04c811c0c598d1f27fb25bfc2 
  staging/kmediaplayer/src/kmediaplayer/player.cpp a4618c4b1d93e2203cea496c100a0ed4ebe4d8dd 
  staging/kmediaplayer/src/kmediaplayer/player.h c59c06fca0ea22994a7f00c6c509777be09370f1 
  staging/kmediaplayer/src/kmediaplayer/view.cpp eb2b779e8a4b044c1aa4f57b15567688da51a626 

Diff: http://git.reviewboard.kde.org/r/113881/diff/


Testing
-------

Still builds.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131115/9e53620e/attachment.html>