Review Request 113883: Rename translation catalogue kfileaudiopreview4 to kfileaudiopreview
Alex Merry
kde at randomguy3.me.uk
Fri Nov 15 20:57:35 UTC 2013
> On Nov. 15, 2013, 12:32 p.m., Aleix Pol Gonzalez wrote:
> > Why do you need to drop the version? In similar cases we've been bumping to 5...
>
> Kevin Ottens wrote:
> Yeah I'm surprised as well... OTOH that's a regular library, we don't mention the version name for those (unlike for executables like kded)
>
> Albert Astals Cid wrote:
> FWIW This is not about library versioning but about the po catalog naming.
I have no preference either way, only that it shouldn't be "4".
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113883/#review43729
-----------------------------------------------------------
On Nov. 15, 2013, 12:22 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113883/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2013, 12:22 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Rename translation catalogue kfileaudiopreview4 to kfileaudiopreview
>
>
> Diffs
> -----
>
> staging/kmediaplayer/src/kfileaudiopreview/Messages.sh 71c7067f3431c1d6d7e920285f1e7382d4218d2d
> staging/kmediaplayer/src/kfileaudiopreview/kfileaudiopreview.cpp 04efb249caca5639e3531b092681ce7fba0e8b05
> staging/kmediaplayer/src/kfileaudiopreview/mediacontrols_p.h bb36ab1bada192e8f80b217fe782b1a96016ada3
>
> Diff: http://git.reviewboard.kde.org/r/113883/diff/
>
>
> Testing
> -------
>
> Builds.
>
>
> Thanks,
>
> Alex Merry
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131115/69240c55/attachment.html>
More information about the Kde-frameworks-devel
mailing list