Review Request 113631: Allow compiling kwindowsystem on Windows

Alexander Richardson arichardson.kde at googlemail.com
Fri Nov 15 19:06:02 UTC 2013



> On Nov. 10, 2013, 6:08 p.m., Patrick von Reth wrote:
> > please use winsock2.h instead of winsock.h
> 
> Kevin Ottens wrote:
>     Alexander? Any chance to see this comment addressed?

Oops somehow didn't see that comment. Sure I will fix it right away. Any other objections or can I commit after changing the include?


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113631/#review43369
-----------------------------------------------------------


On Nov. 10, 2013, 4:46 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113631/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2013, 4:46 p.m.)
> 
> 
> Review request for KDE Frameworks, Patrick Spendrin and Patrick von Reth.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Allow compiling kwindowsystem on Windows
> 
> 
> Diffs
> -----
> 
>   tier1/CMakeLists.txt 277b3f0 
>   tier1/kwindowsystem/CMakeLists.txt dc8fcae 
>   tier1/kwindowsystem/src/CMakeLists.txt d9d141e 
>   tier1/kwindowsystem/src/kkeyserver_win.h 6328f41 
>   tier1/kwindowsystem/src/kstartupinfo.h 39c2935 
>   tier1/kwindowsystem/src/kstartupinfo.cpp 402cc97 
>   tier1/kwindowsystem/src/kwindowinfo_win.cpp d392fe9 
>   tier1/kwindowsystem/src/kwindowsystem.h 0c6a930 
>   tier1/kwindowsystem/src/kwindowsystem_win.cpp 23a6616 
> 
> Diff: http://git.reviewboard.kde.org/r/113631/diff/
> 
> 
> Testing
> -------
> 
> Compiles (Windows 7, VS 2012 x64)
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131115/a6d96a8b/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list