Review Request 113851: Unbreak kauth-policy-gen
Aurélien Gâteau
agateau at kde.org
Thu Nov 14 09:38:31 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113851/
-----------------------------------------------------------
(Updated Nov. 14, 2013, 10:38 a.m.)
Review request for KDE Frameworks.
Changes
-------
--trailing-space
Repository: kdelibs
Description
-------
This is a two-commit patch, it fixes a build failure in kde-workspace/kcontrol/dateandtime.
1. make policy-gen accept a second argument pointing to the output file
2. Unbreak call to kauth-policy-gen
Uses the new kauth-policy-gen syntax for extra safety (no empty output file
gets created in case of failure)
Note: I haven't tested the Mac part of the code. Would be awesome if someone could give it a try.
Diffs (updated)
-----
tier2/kauth/KAuthConfig.cmake.in 67eb7de
tier2/kauth/cmake/KAuthMacros.cmake 1ebc889
tier2/kauth/src/CMakeLists.txt 68c7c37
tier2/kauth/src/policy-gen/policy-gen.cpp b00e09f
Diff: http://git.reviewboard.kde.org/r/113851/diff/
Testing
-------
Still builds, kcmclock_actions.policy is correctly generated in kde-workspace/kcontrol/dateandtime
Thanks,
Aurélien Gâteau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131114/c4e1d6d3/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list