Review Request 113792: Fix Build of KDNSSD with DNSSD Backend

Kevin Ottens ervin at kde.org
Wed Nov 13 20:42:12 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113792/#review43628
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On Nov. 11, 2013, 1:32 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113792/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2013, 1:32 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Adjusting the code to changes in Qt5.
> 
> The nature of the changes makes me wonder if this code is maintained at all or if the DNSSD backend should be dropped.
> 
> 
> Diffs
> -----
> 
>   tier2/dnssd/src/mdnsd-servicebrowser.cpp 37449db 
>   tier2/dnssd/src/mdnsd-publicservice.cpp 5da6f97 
>   tier2/dnssd/src/mdnsd-domainbrowser.cpp 21c359e 
>   tier2/dnssd/src/CMakeLists.txt c71ade2 
>   tier2/dnssd/CMakeLists.txt 13497d1 
> 
> Diff: http://git.reviewboard.kde.org/r/113792/diff/
> 
> 
> Testing
> -------
> 
> 1. Configure KDNSSD with -DCMAKE_DISABLE_FIND_PACKAGE_Avahi=1
> 2. Build
> 
> Builds successfully.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131113/57fd4b53/attachment.html>


More information about the Kde-frameworks-devel mailing list