Review Request 113821: Don't install kpagedialog_p.h

Aleix Pol Gonzalez aleixpol at kde.org
Wed Nov 13 15:43:55 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113821/
-----------------------------------------------------------

(Updated Nov. 13, 2013, 3:43 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Repository: kdelibs


Description
-------

This makes sure that KWidgetsAddons doesn't expose any private dependencies.

The only user of that file was KCMultiDialogPrivate. This patch refactors the code so that it's used separately.


Diffs
-----

  tier1/kwidgetsaddons/src/CMakeLists.txt 76679a4 
  tier4/kcmutils/src/kcmultidialog.h 3518736 
  tier4/kcmutils/src/kcmultidialog.cpp 9d2ccbb 
  tier4/kcmutils/src/kcmultidialog_p.h ad5dd98 

Diff: http://git.reviewboard.kde.org/r/113821/diff/


Testing
-------

Everything builds, couldn't test since I didn't see any test.

Tests still pass though.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131113/3419c188/attachment.html>


More information about the Kde-frameworks-devel mailing list