Review Request 113685: New KColorSchemeManager to support changing color scheme in app

[Christoph Feck]

> On Nov. 12, 2013, 10:49 p.m., Albert Astals Cid wrote:
> > About the .colors translations, we have this
> > 
> > ./kdeui/colors/kcolordialog.cpp:104:    { "40.colors",     I18N_NOOP2("palette name", "Forty Colors") },
> > ./kdeui/colors/kcolordialog.cpp:105:    { "Oxygen.colors", I18N_NOOP2("palette name", "Oxygen Colors") },
> > ./kdeui/colors/kcolordialog.cpp:106:    { "Rainbow.colors", I18N_NOOP2("palette name", "Rainbow Colors") },
> > ./kdeui/colors/kcolordialog.cpp:107:    { "Royal.colors",  I18N_NOOP2("palette name", "Royal Colors") },
> > ./kdeui/colors/kcolordialog.cpp:108:    { "Web.colors",    I18N_NOOP2("palette name", "Web Colors") },
> > 
> > Not sure if this is the only place that it's used or not. Maybe we need a more central class that handles for you the search for "*.colors" and then gives you both an "internal" name and an "user visible" name?
> 
> Martin Gräßlin wrote:
>     That doesn't look like a useable solution. Kcolordialog lives in kde4support while the .colors are in kde-workspace. I think the translations would need to go with the .colors files directly.
> 
> Boudewijn Rempt wrote:
>     Hm... But what do the .colors files which are, as far as I know palettes, have to do with color themes for apps?

You are right, those are two different beasts. The palettes are only shown in the color picker dialog, while the color themes are those that affect application colors.


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113685/#review43557
-----------------------------------------------------------


On Nov. 12, 2013, 8:48 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113685/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2013, 8:48 a.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Gilles Caulier, and Boudewijn Rempt.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This class is inspired by functionality offered by e.g. Krita and
> Digikam to allow the user to select a different color scheme for the
> application.
>     
> This manager simplifies this task and also ensures that the required
> property on QApplication is set, so that a QStyle can pass the scheme
> to the window manager/compositor for the windows of the application.
> 
> @boud and @cgilles: please have a look whether this approach is sufficient for your usecases in digkam and Krita.
> 
> 
> Diffs
> -----
> 
>   tier3/kconfigwidgets/src/CMakeLists.txt 36ffca8 
>   tier3/kconfigwidgets/src/kcolorschememanager.h PRE-CREATION 
>   tier3/kconfigwidgets/src/kcolorschememanager.cpp PRE-CREATION 
>   tier3/kconfigwidgets/src/kcolorschememanager_p.h PRE-CREATION 
>   tier3/kconfigwidgets/tests/CMakeLists.txt f66dc32 
>   tier3/kconfigwidgets/tests/kcolorschemedemo.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113685/diff/
> 
> 
> Testing
> -------
> 
> see demo application
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131113/b652fb48/attachment-0001.html>