Review Request 113683: Fix kdeclarative standalone build

Aleix Pol Gonzalez aleixpol at kde.org
Tue Nov 12 21:38:12 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113683/#review43555
-----------------------------------------------------------

Ship it!


No, if it works just push it.

- Aleix Pol Gonzalez


On Nov. 12, 2013, 7:52 p.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113683/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2013, 7:52 p.m.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez and Aurélien Gâteau.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Make kdeclarative build standalone.
> 
> Do I need to add the dependencies of all dependencies as well now?
> 
> 
> Diffs
> -----
> 
>   superbuild/CMakeLists.txt 56e17dd42a8cc2b2c8a0015c7c5ec74902e0bd3e 
>   tier3/kdeclarative/CMakeLists.txt 1f23914a0ba65982c7b597e92fe9c9e920e2abe6 
> 
> Diff: http://git.reviewboard.kde.org/r/113683/diff/
> 
> 
> Testing
> -------
> 
> Builds.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131112/7da06598/attachment.html>


More information about the Kde-frameworks-devel mailing list