Review Request 113805: Do not change the build types available with cmake

[Alexander Neundorf]

> On Nov. 12, 2013, 12:02 a.m., Aleix Pol Gonzalez wrote:
> > Maybe I've missed something, but I would like to have it explained somehow. Why is it bad to define such values? How will g++ calls compare?
> 
> Nicolás Alvarez wrote:
>     In normal CMake, -DCMAKE_BUILD_TYPE=Debug builds without optimization and with debugging symbols. But in KDE projects, Debug uses "-O2 -g" and there's a custom type called "Debugfull" which uses "-O0 -g".
>     
>     This patch removes all the custom stuff so that "Debug" means the same (debug, no opts) whether it's a KDE project or not. To get "-O2 -g" there's RelWithDebInfo.
> 
> Aleix Pol Gonzalez wrote:
>     It's also removing the debugfull mode (which is the one that everybody uses, AFAIK), which uses -g3.
> 
> David Faure wrote:
>     I'm in favour of not redefining what cmake already defines, to avoid surprises.
>     
>     However we could keep debugfull on top of the cmake build types, it doesn't hurt, and can be useful to step into macros in gdb.
>     (I can't remember doing that, but maybe I did it without realizing ;)
> 
> David Faure wrote:
>     OK, the alternative is of course to submit a patch to cmake to change Debug from -g to -g3. That's the best solution, of course. Alex? Stephen?
> 
> Alexander Neundorf wrote:
>     Changing that in cmake changes the defaults for every cmake user. I personally don't feel comfortable changing that in cmake.
>     
>     For more see my other comment here.
>

Indeed it doesn't look like it: http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/8609/focus=8614


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113805/#review43480
-----------------------------------------------------------


On Nov. 11, 2013, 10:16 p.m., Sune Vuorela wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113805/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2013, 10:16 p.m.)
> 
> 
> Review request for Build System and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Do not change the build types available with cmake.
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDECompilerSettings.cmake b034751a5be8073f9628971b552faa079c64e8b6 
> 
> Diff: http://git.reviewboard.kde.org/r/113805/diff/
> 
> 
> Testing
> -------
> 
> Built kdelibs on linux with gcc.
> 
> 
> Thanks,
> 
> Sune Vuorela
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131112/1900cbb8/attachment-0001.html>