Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113506/#review43533
-----------------------------------------------------------



CMakeLists.txt
<http://git.reviewboard.kde.org/r/113506/#comment31301>

    I don't think we want that, superbuild shouldn't be used after the splitting but the kde build script. We will need it anyway and it will have all the needed information anyway.


I agree that the rest of the changes are good and they should go in, having to enable all modules one by one is annoying.

- Aleix Pol Gonzalez


On Nov. 7, 2013, 2:42 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113506/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2013, 2:42 p.m.)
> 
> 
> Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This patch rework superbuild to integrate it more closely with kdelibs build system: one no longer needs to run cmake path/to/kdelibs/superbuild separately. Instead targets are created for all frameworks declared in superbuild/CMakeLists.txt. For example to build and install ki18n standalone, one can run `make sb_ki18n`. It also adds a special "sb_all" target, which builds and install all standalone frameworks.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 879fed4 
>   superbuild/CMakeLists.txt cbe9630 
>   superbuild/README 7a4e52e 
>   superbuild/SuperBuild.cmake 33ed151 
> 
> Diff: http://git.reviewboard.kde.org/r/113506/diff/
> 
> 
> Testing
> -------
> 
> kdelibs still builds standalone, all sb_* targets work as expected.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131112/f8d6bd02/attachment.html>