Review Request 113816: Improve KDBusAddons API docs

David Faure faure at kde.org
Tue Nov 12 15:31:01 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113816/#review43523
-----------------------------------------------------------

Ship it!


Many thanks, this is good stuff.


tier1/kdbusaddons/src/kdbusservice.h
<http://git.reviewboard.kde.org/r/113816/#comment31295>

    (not related to this commit, but this makes me re-read this paragraph, and Thiago made me realize meanwhile that as long as the eventloop doesn't run, there's no race even if the objects are exported after registering to the bus). I can fix this later if you want.


- David Faure


On Nov. 12, 2013, 12:16 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113816/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2013, 12:16 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Kevin Ottens.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Improve KDBusAddons API docs
> 
> 
> Diffs
> -----
> 
>   tier1/kdbusaddons/src/kdbusservice.h f7def3b9daa38fc739b9b879b5a2b6df7e397657 
> 
> Diff: http://git.reviewboard.kde.org/r/113816/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131112/4e136b70/attachment.html>


More information about the Kde-frameworks-devel mailing list