Review Request 113796: KDBusService: only register desktop activation object for Unique apps

[Alex Merry]

> On Nov. 11, 2013, 5:28 p.m., David Faure wrote:
> > I'm not sure this is a good idea.
> > 
> > Yes, the spec for this (e.g. for app launchers) is only about unique apps, but I still want to be able to start a konqueror instance (org.kde.konqueror-12345) and then make a dbus call to have it open a URL, or trigger some action, in a custom script. What's the harm in keeping that dbus interface exposed for non-unique apps?

None, providing the users of the class are aware of this.  I'm happy to change the API docs instead.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113796/#review43446
-----------------------------------------------------------


On Nov. 11, 2013, 3:58 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113796/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2013, 3:58 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Kevin Ottens.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> KDBusService: only register desktop activation object for Unique apps
> 
> The Desktop Activation stuff only really makes sense for Unique apps
> (only they will have the correct service name, for a start).
> 
> 
> Diffs
> -----
> 
>   tier1/kdbusaddons/src/kdbusservice.cpp b773c80b30c6ee39d6d8b4d8c962b83dbd87f7d4 
> 
> Diff: http://git.reviewboard.kde.org/r/113796/diff/
> 
> 
> Testing
> -------
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131111/884b1e5f/attachment.html>