Review Request 113795: Cut dependency from KIO to KCoreAddons private headers
David Faure
faure at kde.org
Mon Nov 11 17:47:25 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113795/#review43450
-----------------------------------------------------------
Ship it!
Assuming tests pass :)
- David Faure
On Nov. 11, 2013, 12:28 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113795/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2013, 12:28 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Make KIO::Job have a separate private class to KJob.
>
> It's a bit less optimal, but it will simplify KCoreAddons development.
>
>
> Diffs
> -----
>
> staging/kio/src/core/job.cpp 8afc51b
> staging/kio/src/core/job_p.h 55c00fa
> staging/kio/src/core/jobclasses.h fb5051c
>
> Diff: http://git.reviewboard.kde.org/r/113795/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131111/168826d4/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list