Review Request 113798: KDBusService: pass the desktop startup ID when calling Activate

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113798/
-----------------------------------------------------------

Review request for KDE Frameworks, David Faure and Kevin Ottens.


Repository: kdelibs


Description
-------

KDBusService: pass the desktop startup ID when calling Activate

We use a bit of private API to ask the xcb platform plugin for it
directly.

The TODO in the original code suggested getting a method in QApplication (or one of its ancestors) to get the startup id, but I think that's very unlikely to be accepted.

There's still the hooks to make use of the value on the other side to sort out, though.


Diffs
-----

  tier1/kdbusaddons/CMakeLists.txt 78cc44333574355ff8504481fcb9c88cfc90daf5 
  tier1/kdbusaddons/src/CMakeLists.txt 0509015afd2d24d34f85a7d6fd786092820814bf 
  tier1/kdbusaddons/src/config-kdbusaddons.h.cmake PRE-CREATION 
  tier1/kdbusaddons/src/kdbusservice.cpp b773c80b30c6ee39d6d8b4d8c962b83dbd87f7d4 

Diff: http://git.reviewboard.kde.org/r/113798/diff/


Testing
-------

Builds, tests pass.  A quick-hack modification of the autotest, along with some hacked-in debug statements, show the value is getting passed properly.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131111/9029a84d/attachment.html>